pc: use absolute lib directory #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INSTALL_LIB_DIR is set to CMAKE_INSTALL_LIB_DIR, and while CMAKE_INSTALL_PREFIX is prepended during install [1], this is not the case for the pkg-config file. Thus, use the full absolute path CMAKE_INSTALL_FULL_LIBDIR for generating the pkg-config file lib directory variables. [1] https://gitlab.kitware.com/cmake/cmake/-/issues/20250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTALL_LIB_DIRis set toCMAKE_INSTALL_LIB_DIR, and whileCMAKE_INSTALL_PREFIXis prepended during install [1], this is not the case for the pkg-config
file. Thus, use the full absolute path
CMAKE_INSTALL_FULL_LIBDIRfor generatingthe pkg-config file lib directory variables.
I originally saw this issue while building a package
vfrnavwhich indirectly depended on minizip, wherelibtoolcomplained thatlib64did not exist because-Llib64was being passed to the linker, which was coming from minizip's pkg-config file [2].[1] https://gitlab.kitware.com/cmake/cmake/-/issues/20250
[2] https://src.fedoraproject.org/rpms/libpqxx/pull-request/7